[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

[Alex Langford via Phabricator via lldb-commits]

bulbazord added inline comments.


================
Comment at: lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp:127
          llvm::Triple::hexagon, llvm::Triple::mips, llvm::Triple::mips64el,
-         llvm::Triple::mipsel, llvm::Triple::systemz},
+         llvm::Triple::mipsel, llvm::Triple::msp430, llvm::Triple::systemz},
         llvm::Triple::Linux);
----------------
DavidSpickett wrote:
> If this is bare metal why do we have changes to Linux code here? Or is this the default platform used when connecting to the msp430 debug stub.
> 
> That said, I'm not sure we A: support Hexagon or B: it runs linux either :)
Hexagon is definitely supported AFAIK but I'm not sure it runs Linux. It does looks like we support an SysV ABI class for Hexagon though, so perhaps that's somewhat indicative that it runs something with that ABI...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146965/new/

https://reviews.llvm.org/D146965