[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/cmake/modules/AddLLDB.cmake:175
+        CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU")
+      target_compile_options(${name} PRIVATE "-fvisibility=default")
+    endif()
----------------
JDevlieghere wrote:
> Rather than changing the compile options directly, can we change the `CXX_VISIBILITY_PRESET` property?
> 
> ```
> set_target_properties((${name} PROPERTIES CXX_VISIBILITY_PRESET default)
> ```
Thanks @JDevlieghere , that works and is cleaner


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147453/new/

https://reviews.llvm.org/D147453