[Lldb-commits] [PATCH] D146286: [lldb][PDB] Rename GetDeclarationForSymbol() -> AddSourceInfoToDecl()
David Spickett via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Mar 17 04:57:06 PDT 2023
DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added a comment.
Agreed, the original name sounds like a const method.
Although I can see why it might have been this way because before optional there was no way to have a null return. So it's return a bool and a ref to the result.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146286/new/
https://reviews.llvm.org/D146286
More information about the lldb-commits
mailing list