[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

Tue Mar 14 12:33:35 PDT 2023

AryanGodara added a comment.

In D146041#4193172 <https://reviews.llvm.org/D146041#4193172>, @junaire wrote:

> I'm not certain if it's bad to say 'sorry', IMHO it's fine?
>
> Anyway, you can't just simply delete those words (in diagnostic messages and regression tests), that doesn't work. To verify the patch is good, you can run `ninja check-all` to make sure the testsuite passes.

This was one of the issues for Outreachy '23, and I asked my outreachy mentor to work on this issue.
I'm looking for any help to make the patch more meaningful, and get guidance along the way.

I'll run `ninja check-all`, before pushing the next commit for revision.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146041/new/

https://reviews.llvm.org/D146041