[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

[David Chisnall via Phabricator via lldb-commits]

theraven added inline comments.


================
Comment at: lldb/test/CMakeLists.txt:39
+if (LLDB_TEST_OBJC_GNUSTEP_DIR)
+  message(STATUS "Found GNUstep ObjC runtime: ${LLDB_TEST_OBJC_GNUSTEP_DIR}/${gnustep_info}")
+endif()
----------------
DavidSpickett wrote:
> sgraenitz wrote:
> > Might be worth a `FindGNUstep.cmake` at some point? (Or is there one somewhere?)
> > 
> > Windows default install dir:
> > ```
> > -- Found GNUstep ObjC runtime: C:/Program Files (x86)/libobjc/lib/objc.dll
> > ```
> > 
> > Linux default install dir:
> > ```
> > -- Found GNUstep ObjC runtime: /usr/local/lib/libobjc.so
> > ```
> I think we generally use UPPERCASE names for cmake variables.
This is somewhat complicated.  If `gnustep-config` exists, the runtime supports installing itself into a location defined by the gnustep-make install, which supports NeXT, Apple, and FHS-style layouts.  It's probably not worth trying to autodetect the general case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146058/new/

https://reviews.llvm.org/D146058