[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

Junchang Liu via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 13 05:53:37 PDT 2023


paperchalice added a comment.

Ping.



================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangHost.cpp:56
+  const std::string clang_resource_path =
+      clang::driver::Driver::GetResourcesPath("bin/lldb", CLANG_RESOURCE_DIR);
 
----------------
Should be "${CMAKE_INSTALL_BINDIR}/lldb" here, but need another variable in `config.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141907/new/

https://reviews.llvm.org/D141907



More information about the lldb-commits mailing list