[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted
Michael Buch via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Dec 1 01:09:46 PST 2022
Michael137 added inline comments.
================
Comment at: lldb/source/Target/Target.cpp:1686
+ const bool should_flush_type_systems =
+ module_list.AllOf([](const lldb::ModuleSP &module_sp) {
+ if (!module_sp)
----------------
kastiglione wrote:
> How come this is `AllOf` and not a `AnyOf`?
Here I'm checking whether all unloaded modules are regular executables or object files. Otherwise we wouldn't want to clear the TypeSystems. E.g., for JITted modules this would not be desirable. I'll add a comment about this
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138724/new/
https://reviews.llvm.org/D138724
More information about the lldb-commits
mailing list