[Lldb-commits] [PATCH] D135921: [WIP][lldb][Breakpoint] Fix setting breakpoints on templates by basename
Michael Buch via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Oct 14 03:47:17 PDT 2022
Michael137 added inline comments.
================
Comment at: lldb/unittests/Language/CPlusPlus/CPlusPlusLanguageTest.cpp:167
+ EXPECT_TRUE(reference_4.ContainsPath("operator"));
EXPECT_TRUE(reference_4.ContainsPath("operator bool"));
----------------
labath wrote:
> Is this actually expected? Like, I don't think it's completely wrong, but I definitely did not expect it to do that.
I agree, it's not intuitive. This happens because `operator` is a reserved keyword in the eyes of the `CPlusPlusNameParser`. It will just consume the entire token and return an empty string.
This won't work for the breakpoint matching logic. I thought we'd just test it here in case the someone ever decides to change this behaviour
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135921/new/
https://reviews.llvm.org/D135921
More information about the lldb-commits
mailing list