[Lldb-commits] [PATCH] D135577: Summary:

Mon Oct 10 10:22:44 PDT 2022

JDevlieghere added inline comments.

================
Comment at: lldb/tools/lldb-vscode/README.md:39

+It is important to note that the directory `~/.vscode/extensions` works for users logged in locally to the machine. If you are remoting into the box using Visual Studio Code's Remote plugins (SSH, WSL, Docker) it will look for extensions on `~/.vscode-server/extensions` only and you will not see your just installed lldb-vscode plug-in. If you want this plugin to be visible to remoting users, you will need to either repeat the process above for the `~/.vscode-server` folder or create a symbolic link from it to `~/.vscode/extensions`:
+
----------------
HenriqueBucher wrote:
> JDevlieghere wrote:
> > Please wrap this so it fits in the 80 col limit. 
> Most of this file has lines with more than 80 columns. Would you want the other lines to be reformatted as well?
I wouldn't say "most": there are a few lines that exceed the 80 col limit for a valid reason (i.e. having a URL in them) but you're right that there's a few lines that should be reflowed (line 25 for example). Since that would be orthogonal to this patch, it should be a separate patch. For the same reason there's no expectation for you to do that, but it would of course be very much appreciated! 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135577/new/

https://reviews.llvm.org/D135577