[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

[Sujin Park via Phabricator via lldb-commits]

persona0220 updated this revision to Diff 443281.
persona0220 marked 4 inline comments as done.
persona0220 added a comment.
Herald added a subscriber: mgorny.

- Delete PTI_MAP enum and use opcode_len instead.
- Add a unit test
  - Divide existing Disassembler test into x86 / ARM subdirectory
  - Unittests/Disassembler/x86/TestGetControlFlowKindx86.cpp tests categorizing x86_64 instructions
- Modify GetControlFlowKind function to get ArchSpec instead of exe_ctx


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128477/new/

https://reviews.llvm.org/D128477

Files:
  lldb/include/lldb/Core/Disassembler.h
  lldb/include/lldb/Target/TraceDumper.h
  lldb/include/lldb/lldb-enumerations.h
  lldb/source/API/SBInstruction.cpp
  lldb/source/API/SBInstructionList.cpp
  lldb/source/Commands/CommandObjectDisassemble.cpp
  lldb/source/Commands/CommandObjectDisassemble.h
  lldb/source/Commands/CommandObjectThread.cpp
  lldb/source/Commands/Options.td
  lldb/source/Core/Disassembler.cpp
  lldb/source/Core/DumpDataExtractor.cpp
  lldb/source/Expression/IRExecutionUnit.cpp
  lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp
  lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
  lldb/source/Symbol/Function.cpp
  lldb/source/Symbol/Symbol.cpp
  lldb/source/Target/ThreadPlanTracer.cpp
  lldb/source/Target/TraceDumper.cpp
  lldb/unittests/Disassembler/ARM/CMakeLists.txt
  lldb/unittests/Disassembler/ARM/TestArm64Disassembly.cpp
  lldb/unittests/Disassembler/ARM/TestArmv7Disassembly.cpp
  lldb/unittests/Disassembler/CMakeLists.txt
  lldb/unittests/Disassembler/TestArm64Disassembly.cpp
  lldb/unittests/Disassembler/TestArmv7Disassembly.cpp
  lldb/unittests/Disassembler/x86/CMakeLists.txt
  lldb/unittests/Disassembler/x86/TestGetControlFlowKindx86.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128477.443281.patch
Type: text/x-patch
Size: 38199 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220708/753e07fd/attachment-0001.bin>