[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

[Sujin Park via Phabricator via lldb-commits]

persona0220 updated this revision to Diff 442417.
persona0220 marked 13 inline comments as done.
persona0220 added a comment.

- Terms ‘control flow kind’ and ‘control flow type’ was mixed across source codes -> Unify into ‘control flow kind’
- Divide the ‘GetControlFlowKind’ function into two functions’:
  - InstructionLengthDecode: Decode raw instruction bytes into opcode, modrm and map.
  - MapOpcodeIntoControlFlowKind: Get control flow find from opcode, modrm and map.
- Add detailed comments for each new functions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128477/new/

https://reviews.llvm.org/D128477

Files:
  lldb/include/lldb/Core/Disassembler.h
  lldb/include/lldb/Target/TraceDumper.h
  lldb/include/lldb/lldb-enumerations.h
  lldb/source/API/SBInstruction.cpp
  lldb/source/API/SBInstructionList.cpp
  lldb/source/Commands/CommandObjectDisassemble.cpp
  lldb/source/Commands/CommandObjectDisassemble.h
  lldb/source/Commands/CommandObjectThread.cpp
  lldb/source/Commands/Options.td
  lldb/source/Core/Disassembler.cpp
  lldb/source/Core/DumpDataExtractor.cpp
  lldb/source/Expression/IRExecutionUnit.cpp
  lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp
  lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
  lldb/source/Symbol/Function.cpp
  lldb/source/Symbol/Symbol.cpp
  lldb/source/Target/ThreadPlanTracer.cpp
  lldb/source/Target/TraceDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128477.442417.patch
Type: text/x-patch
Size: 30750 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220706/6667d9e2/attachment-0001.bin>