[Lldb-commits] [PATCH] D127819: [trace][intelpt] Support system-wide tracing [21] - Support long numbers in JSON

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/source/Utility/TraceIntelPTGDBRemotePackets.cpp:25
 
+json::Value toJSON(const JSONUINT64 &uint64, bool hex) {
+  if (hex)
----------------
jj10306 wrote:
> should there be an option to write it as an integer or would the user just be expected to use a raw u64 in that case?
I'd prefer us to emit only string numbers, but to leave the option for external tools to emit non-string decimals


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127819/new/

https://reviews.llvm.org/D127819