[Lldb-commits] [PATCH] D125932: [trace][intelpt] Support system-wide tracing [10] - Return warnings and tsc information from lldb-server.
Jakob Johnson via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri May 27 12:45:45 PDT 2022
jj10306 added inline comments.
================
Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.cpp:40
+IntelPTCollector::FetchPerfTscConversionParameters() {
+ if (!m_cached_tsc_conversion) {
+ if (Expected<LinuxPerfZeroTscConversion> tsc_conversion =
----------------
Don't we want to always reload the parameters here (ie not do this check) since they could potentially change or is that not the case?
We had discussions about this when I initially added the tsc conversion logic but I can't remember so maybe you can help refresh my memory:
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125932/new/
https://reviews.llvm.org/D125932
More information about the lldb-commits
mailing list