[Lldb-commits] [lldb] f179f40 - [lldb] Disable modules in Apple-lldb-base

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2022-05-24T17:17:14-07:00
New Revision: f179f403c8579c939e09d27c383b6263cf2523aa

URL: https://github.com/llvm/llvm-project/commit/f179f403c8579c939e09d27c383b6263cf2523aa
DIFF: https://github.com/llvm/llvm-project/commit/f179f403c8579c939e09d27c383b6263cf2523aa.diff

LOG: [lldb] Disable modules in Apple-lldb-base

The LLDB website recommends using the CMake caches to build on macOS.
Although modules result in a faster build, this configuration tends to
break occasionally because it's specific to our platform. I don't expect
newcomers to be able to deal with those kind of breakages so don't
enable them by default.

Added: 
    

Modified: 
    lldb/cmake/caches/Apple-lldb-base.cmake

Removed: 
    


################################################################################
diff  --git a/lldb/cmake/caches/Apple-lldb-base.cmake b/lldb/cmake/caches/Apple-lldb-base.cmake
index 76ab843c4b6b7..4d4f02bfae95b 100644
--- a/lldb/cmake/caches/Apple-lldb-base.cmake
+++ b/lldb/cmake/caches/Apple-lldb-base.cmake
@@ -3,7 +3,6 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON CACHE BOOL "")
 
 set(LLVM_TARGETS_TO_BUILD X86;ARM;AArch64 CACHE STRING "")
 set(LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "")
-set(LLVM_ENABLE_MODULES ON CACHE BOOL "")
 
 set(LIBCXX_ENABLE_SHARED OFF CACHE BOOL "")
 set(LIBCXX_ENABLE_STATIC OFF CACHE BOOL "")