[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

[Greg Clayton via Phabricator via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

We can't change any public API calls since other tools might link against the existing API, but we can add new variants to the API. Inline fixes have been suggested.



================
Comment at: lldb/bindings/interface/SBProcess.i:400-401
 
     lldb::SBError
-    SaveCore(const char *file_name);
+    SaveCore(const char *file_name, const char *plugin_name);
 
----------------
We can't change public API, but we can add variants.


================
Comment at: lldb/include/lldb/API/SBProcess.h:341-342
   /// Save the state of the process in a core file (or mini dump on Windows).
-  lldb::SBError SaveCore(const char *file_name);
+  lldb::SBError SaveCore(const char *file_name,
+                         const char *plugin_name = "");
 
----------------
We have a public API, we cannot change any existing functions in the API, but we are free too add new variants.


================
Comment at: lldb/source/API/SBProcess.cpp:1139-1141
+lldb::SBError SBProcess::SaveCore(const char *file_name,
+                                  const char *plugin_name) {
+  LLDB_INSTRUMENT_VA(this, file_name, plugin_name);
----------------
Can't change public API, so just. add a new variant.


================
Comment at: lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py:46-47
             self.runCmd("process save-core --plugin-name=minidump --style=stack " + core)
+            # validate savinig via SBProcess
+            lldb.SBProcess().SaveCore(core_sb, "minidump")
             self.assertTrue(os.path.isfile(core))
----------------
revert this as we should be able to still save a core file without specifying the plug-in name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125325/new/

https://reviews.llvm.org/D125325