[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added a comment.

In D120718#3352450 <https://reviews.llvm.org/D120718#3352450>, @JDevlieghere wrote:

> I think the better solution here is to get rid of the `using namespace llvm;` in the implementation file instead.

That is a good point. I did a quick look at the file `DataFileCache.h` and none of the files it includes directly use `using namespace llvm;`.

It looks like across llvm-project we have 54 headers that use `using namespace llvm;` I thought it was a lot more.

I personally dislike it even in `.cpp` files using `llvm::` or `lldb_private::` does not feel like an undue burden. Although the count for `.cpp` files is 4000+ 😱


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120718/new/

https://reviews.llvm.org/D120718