[Lldb-commits] [PATCH] D118482: [lldb/Plugins] Add ScriptedProcessInterface::GetSelectedThreadIndex method

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 28 10:15:30 PST 2022


shafik added a comment.

Just nitpicks



================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:362
   // previous thread state (if any).
+  uint32_t selected_thread_index = GetInterface().GetSelectedThreadIndex();
+
----------------
`const`


================
Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp:123
+
+  uint64_t val = obj->GetIntegerValue(LLDB_INVALID_INDEX32);
+
----------------
`const`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118482/new/

https://reviews.llvm.org/D118482



More information about the lldb-commits mailing list