[Lldb-commits] [PATCH] D118482: [lldb/Plugins] Add ScriptedProcessInterface::GetSelectedThreadIndex method

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 28 09:15:26 PST 2022


jingham added a comment.

This seems wrong to me.  Normal Processes don't get to choose which thread the generic "which stop event is most important" logic selects, they just report the stop events and then the higher level logic decides which one to select.  It seems more symmetric to have the ScriptedThreads work the same way - after all they are free to assign whatever StopInfo they want to each stop.  Why do you need to force the result in the ScriptedProcess case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118482/new/

https://reviews.llvm.org/D118482



More information about the lldb-commits mailing list