[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

Mon Jan 24 15:00:51 PST 2022

JDevlieghere added a comment.

In D117914#3267657 <https://reviews.llvm.org/D117914#3267657>, @clayborg wrote:

> Yep! Looks good.
>
> As a follow up patch it would be great to ask the SymbolFile classes to break down some memory usage. I know in the SymbolFileDWARF we have each DWARFUnit that may or may not parse the unit DIE or all of the DIEs. These data structures take up memory and we lazily try to only parse all DIEs in a DWARFUnit when we need to. If we index the debug info, we will load the info and remembers which DWARFUnits had all of their DIEs parsed, and after indexing we will free the memory to keep memory usage down.

Are you referring to the `m_die_array` in `DWARFUnit` and `ClearDIEsRWLocked`? If so that actually looks like a good fit for the BumpPtrAllocator in which case it should be fairly easy to report.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117914/new/

https://reviews.llvm.org/D117914