[Lldb-commits] [PATCH] D117382: [NFC] Cleanup log channel stuff to all be consistent and use 64 bit log channel mask.
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jan 14 19:02:48 PST 2022
JDevlieghere added a comment.
Nice improvement!
================
Comment at: lldb/include/lldb/Utility/LLDBLog.h:1
+//===-- Logging.h -----------------------------------------------*- C++ -*-===//
+//
----------------
LLDBLog.h
================
Comment at: lldb/include/lldb/Utility/LLDBLog.h:58
+public:
+ static void Initialize();
+
----------------
Even if it's a NOOP, should we add a `Terminate` for consistency?
================
Comment at: lldb/source/Core/ValueObject.cpp:45-46
#include "lldb/Utility/Flags.h"
-#include "lldb/Utility/Log.h"
-#include "lldb/Utility/Logging.h"
+#include "lldb/Utility/LLDBLog.h"
+#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Scalar.h"
----------------
Dupe
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117382/new/
https://reviews.llvm.org/D117382
More information about the lldb-commits
mailing list