[Lldb-commits] [lldb] c0e4154 - Fix clang-tidy bugprone-argument-comment that was mixed up

[Shafik Yaghmour via lldb-commits]

Author: Shafik Yaghmour
Date: 2022-01-11T11:12:28-08:00
New Revision: c0e415471136a16cc98c9ce57392efd62db51c1f

URL: https://github.com/llvm/llvm-project/commit/c0e415471136a16cc98c9ce57392efd62db51c1f
DIFF: https://github.com/llvm/llvm-project/commit/c0e415471136a16cc98c9ce57392efd62db51c1f.diff

LOG: Fix clang-tidy bugprone-argument-comment that was mixed up

Several of the comments were annotating the wrong argument.

I caught this while reviewing this clean-up: https://github.com/llvm/llvm-project/commit/8afcfbfb8fc1e53023ffac9d9bdc424248d6d2ff

which was changing booleans to use true and false and in the this case the comment and the type looked mismatched.

Differential Revision: https://reviews.llvm.org/D116982

Added: 
    

Modified: 
    lldb/source/Target/TraceInstructionDumper.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Target/TraceInstructionDumper.cpp b/lldb/source/Target/TraceInstructionDumper.cpp
index f0947d8f88b82..d58d2dff7383a 100644
--- a/lldb/source/Target/TraceInstructionDumper.cpp
+++ b/lldb/source/Target/TraceInstructionDumper.cpp
@@ -148,9 +148,8 @@ static void DumpInstructionDisassembly(Stream &s, InstructionSymbolInfo &insn) {
   if (!insn.instruction)
     return;
   s.Printf("    ");
-  insn.instruction->Dump(&s, /*show_address=*/false, /*show_bytes=*/false,
-                         /*max_opcode_byte_size=*/false, &insn.exe_ctx,
-                         &insn.sc,
+  insn.instruction->Dump(&s, /*max_opcode_byte_size=*/0, /*show_address=*/false,
+                         /*show_bytes=*/false, &insn.exe_ctx, &insn.sc,
                          /*prev_sym_ctx=*/nullptr,
                          /*disassembly_addr_format=*/nullptr,
                          /*max_address_text_size=*/0);