[Lldb-commits] [PATCH] D116539: [lldb/platform-gdb] Clear cached protocol state upon disconnection
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jan 10 07:15:33 PST 2022
labath added inline comments.
================
Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:84
bool PlatformAndroidRemoteGDBServer::LaunchGDBServer(lldb::pid_t &pid,
std::string &connect_url) {
uint16_t remote_port = 0;
----------------
JDevlieghere wrote:
> Should this have `assert(IsConnected());` like `PlatformRemoteGDBServer::LaunchGDBServer` does?
Yeah, I guess it should.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116539/new/
https://reviews.llvm.org/D116539
More information about the lldb-commits
mailing list