[Lldb-commits] [PATCH] D116853: [CMake][LLDB] Resolve install conflict when `LLDB_BUILD_FRAMEWORK=ON`

Sun Jan 9 21:32:14 PST 2022

JDevlieghere requested changes to this revision.
JDevlieghere added a comment.
This revision now requires changes to proceed.

Hey LJC. I'm the person maintaining the LLDB framework build, so please include me in any future patches that change that. I'm also on the majority of the blamelist for this file, which is always a useful way to find good reviewers. With that out of the way, I do have a few comments about this patch:

- It doesn't look like the RPATH change is really related to the install target so please create a separate patch for that.
- Note how the function this is (`finish_swig_python`) takes `lldb_python_target_dir` as an input argument. Downstream we create more than one directory, and this patch is going to break that.

You say that `LLDB.framework/Resources/Python` is installed by `liblldb`, but I can't immediately see where that's happening in `API/CMakeLists.txt`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116853/new/

https://reviews.llvm.org/D116853