[Lldb-commits] [PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

Sam McCall via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 3 10:50:19 PST 2022


sammccall added inline comments.


================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:995
   /// \param NumCandidates the number of overload candidates
   void ProcessOverloadCandidates(Sema &S, unsigned CurrentArg,
                                  OverloadCandidate *Candidates,
----------------
kadircet wrote:
> why not just drop the method? it is not pure, and no-op in base too.
That's a reasonable question, but it's not my code so IDK if it's a style thing.
(I was tempted to remove it but it seems gratuitous for this kind of change)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116317/new/

https://reviews.llvm.org/D116317



More information about the lldb-commits mailing list