[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

Martin Storsjö via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Jan 1 12:58:09 PST 2022


mstorsjo added subscribers: beanz, mstorsjo.
mstorsjo added a reviewer: beanz.
mstorsjo added a comment.

This looks reasonable to me, but I'm not sure if I know all the aspects that might be at play here, so I don't think I'm comfortable with accepting it on my own. Adding @beanz who should know lots about our cmake setup too.



================
Comment at: llvm/cmake/modules/CMakeLists.txt:58
 set(LLVM_CONFIG_TOOLS_BINARY_DIR "${LLVM_TOOLS_BINARY_DIR}")
+set(LLVM_CONFIG_LIBRARY_DIR "${LLVM_LIBRARY_DIR}")
 
----------------
Curious: Why the reordering? I presume you're moving `LLVM_CONFIG_CMAKE_DIR` into alphabetical order, but then `LLVM_CONFIG_LIBRARY_DIR` seems out of place?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116467/new/

https://reviews.llvm.org/D116467



More information about the lldb-commits mailing list