[Lldb-commits] [PATCH] D110885: [AttributeList] Replace index_begin/end with an iterator

Arthur Eubanks via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 30 14:18:58 PDT 2021


aeubanks created this revision.
Herald added subscribers: dexonsmith, jdoerfert, arphaman, hiraditya.
aeubanks requested review of this revision.
Herald added projects: LLDB, LLVM.
Herald added subscribers: llvm-commits, lldb-commits.
Herald added a subscriber: JDevlieghere.

We expose the fact that we rely on unsigned wrapping to iterate through
all indexes. This can be confusing. Rather, keeping it as an
implementation detail through an iterator is less confusing and is less
code.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D110885

Files:
  lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp
  llvm/include/llvm/IR/Attributes.h
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/Bitcode/Writer/ValueEnumerator.cpp
  llvm/lib/IR/Attributes.cpp
  llvm/lib/Transforms/Utils/FunctionComparator.cpp
  llvm/tools/llvm-reduce/deltas/ReduceAttributes.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110885.376367.patch
Type: text/x-patch
Size: 5040 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210930/e70629f2/attachment.bin>


More information about the lldb-commits mailing list