[Lldb-commits] [PATCH] D110804: Add a new command "target metrics".
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Sep 30 14:05:54 PDT 2021
clayborg marked 6 inline comments as done.
clayborg added inline comments.
================
Comment at: lldb/include/lldb/Core/Module.h:940
+ /// ElapsedTime
+ double &GetSymtabParseTime() { return m_symtab_parse_time; }
+ double &GetSymtabNamesTime() { return m_symtab_names_time; }
----------------
teemperor wrote:
> labath wrote:
> > teemperor wrote:
> > > Could the `double` and `uint64_t` here/below be a typedef to some unit? `typedef double Seconds`/`typedef uint64_t ByteCount` or something along those lines. Would make the unit we're expecting more obvious and I can easily find all the related code.
> > *cough* *cough* std::chrono *cough* *cough*
> Yeah I didn't want to bring std::chrono in just yet but that would be the next logical step. FWIW, `ElapsedTime::Duration` already seems to be pretty much what we would want here, so we could just use that?
I can switch to ElapsedTime::Duration
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110804/new/
https://reviews.llvm.org/D110804
More information about the lldb-commits
mailing list