[Lldb-commits] [PATCH] D110601: Add -relative-to-command-file to "command source"

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D110601#3026363 <https://reviews.llvm.org/D110601#3026363>, @jingham wrote:

> The one thing that makes me sad about this is that "command script import" chose "-c" as the short letter for this option, but "-c" was already taken for "command source", so I used -C for "command source".

Maybe it's not too late to change the short letter for `command script import`, or we could add `C` as an alias?



================
Comment at: lldb/source/Commands/CommandObjectCommands.cpp:156
+      // doesn't alter paths that are already relative.
+      // Question, should we make it an error to pass -C and an absolute path?
+      cmd_file.MakeAbsolute(source_dir);
----------------
Seems easy enough to detect, so why not?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110601/new/

https://reviews.llvm.org/D110601