[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based Split()

Mon Sep 27 05:15:53 PDT 2021

mgorny marked 3 inline comments as done.
mgorny added a comment.

Filed D110535 <https://reviews.llvm.org/D110535> for suggested changes.

================
Comment at: llvm/include/llvm/ADT/StringExtras.h:527-529
+    std::pair<StringRef, StringRef> Res = Next.split(Separator);
+    Current = Res.first;
+    Next = Res.second;
----------------
labath wrote:
> `std::tie(Current, Next) = ...`
Damnit, I swear it didn't work before! Complained about `this` pointer something.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110496/new/

https://reviews.llvm.org/D110496