[Lldb-commits] [PATCH] D108717: Fix Reference case for TypeSystemClang::GetChildCompilerTypeAtIndex(...) to avoid possible invalid cast

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

That looks obviously correct, thanks!



================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:6506
+      CompilerType pointee_clang_type;
+
+      if (parent_type_class == clang::Type::LValueReference)
----------------
maybe use  `= (parent_type_class == clang::Type::LValueReference) ?  GetLValueReferenceType(type).GetPointeeType() : GetRValueReferenceType(type).GetPointeeType()` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108717/new/

https://reviews.llvm.org/D108717