[Lldb-commits] [PATCH] D96947: [lldb] Prevent double new lines behind errors/warning/messages from LLDB commands

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 24 05:42:55 PST 2021


teemperor added inline comments.


================
Comment at: lldb/source/Interpreter/CommandReturnObject.cpp:93
     return;
-  GetOutputStream() << in_string << "\n";
+  GetOutputStream() << in_string;
+  if (!in_string.endswith("\n"))
----------------
JDevlieghere wrote:
> How about rstripping any trailing `\n` and then always adding one? 
I actually like the idea even more. I updated to rstrip and then just add a newline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96947/new/

https://reviews.llvm.org/D96947



More information about the lldb-commits mailing list