[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

Sun Feb 21 11:54:52 PST 2021

labath added a comment.

In D96778#2576881 <https://reviews.llvm.org/D96778#2576881>, @dblaikie wrote:

> In D96778#2573076 <https://reviews.llvm.org/D96778#2573076>, @jankratochvil wrote:
>
>> In D96778#2572816 <https://reviews.llvm.org/D96778#2572816>, @dblaikie wrote:
>>
>>> rolls this into one file with two CUs - bit easier to deal with.
>>
>> Then one could not use the `.file` directives and one would need to code also `.debug_line` by hand.
>
> Ah, right, makes sense.

Not keeping up with the entire debate, just chiming in to say that sometimes one can good results through conditional compilation (`.ifdef` and friends) -- put the common stuff (abbreviations or whatever) in an unconditional block, and the different things into conditional blocks...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96778/new/

https://reviews.llvm.org/D96778