[Lldb-commits] [PATCH] D91922: [lldb] Fix qRegisterInfo to handle missing registers

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 23 00:21:00 PST 2020


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good. I'd rephrase the commit title to make it clearer this only changes the single test, and does not change behavior otherwise...



================
Comment at: lldb/test/API/tools/lldb-server/TestLldbGdbServer.py:588
 
+            # Skip erraneous (unsupported) registers.
+            if p_response.startswith("E") and len(p_response) == 3:
----------------
Maybe add a TODO to remove this once we're able to actually make registers disappear.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91922/new/

https://reviews.llvm.org/D91922



More information about the lldb-commits mailing list