[Lldb-commits] [PATCH] D90313: [lldb] Use reverse connection method for lldb-server tests

Wed Oct 28 09:15:58 PDT 2020

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

In D90313#2359300 <https://reviews.llvm.org/D90313#2359300>, @labath wrote:

> In D90313#2359273 <https://reviews.llvm.org/D90313#2359273>, @JDevlieghere wrote:
>
>> On GreenDragon we've also noticed the increased flakiness and it sounds like it could very well be the same issue? It seems like this would only solve it for lldb-server, while we run these tests with debugserver. The latter doesn't support `--reverse-connect`, so I'm wondering if there's something else we can do to solve the flakiness for both? Should we just return to using `127.0.0.1`?
>
> It does support --reverse-connect, and I've checked that this works with it. The only tricky part is that the option does not show up in its --help output. (it didn't used to show for lldb-server either, that's why I did the libOption patch :P).

Haha, it feels like you read my mind because that's exactly what I checked. Now the pieces are falling in place ;-) LGTM!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90313/new/

https://reviews.llvm.org/D90313