[Lldb-commits] [PATCH] D89875: [nfc] [lldb] Fix harmless slicing of DWARFDIE

Wed Oct 21 06:29:12 PDT 2020

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

> Is return {...}; implicit ctor OK for LLDB? I have found only one line (return {sdk};) in rG5935227e11f5 <https://reviews.llvm.org/rG5935227e11f5b8e7111ee4a076c10a62d0648689> using that syntax and I would normally use it everywhere.

We don't have a policy on that. I personally wouldn't recommend using it literally _everywhere_ (this can get messy in very long function and particularly if you start nesting the `{}`s), but here it's perfectly fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89875/new/

https://reviews.llvm.org/D89875