[Lldb-commits] [PATCH] D89256: [LLDB] Fix 37 tests on Windows

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 12 11:03:23 PDT 2020


amccarth created this revision.
amccarth added a reviewer: JDevlieghere.
Herald added a subscriber: mgorny.
amccarth requested review of this revision.

A Windows-style LLDB_PYTHON_HOME path in a Cmake template didn't have the backslashes escaped, which led to a garbled paths derived from it.  Fixed by expanding the environment variable as a raw string literal.


https://reviews.llvm.org/D89256

Files:
  lldb/include/lldb/Host/Config.h.cmake


Index: lldb/include/lldb/Host/Config.h.cmake
===================================================================
--- lldb/include/lldb/Host/Config.h.cmake
+++ lldb/include/lldb/Host/Config.h.cmake
@@ -52,7 +52,7 @@
 
 #cmakedefine01 LLDB_EMBED_PYTHON_HOME
 
-#cmakedefine LLDB_PYTHON_HOME "${LLDB_PYTHON_HOME}"
+#cmakedefine LLDB_PYTHON_HOME R"(${LLDB_PYTHON_HOME})"
 
 #define LLDB_LIBDIR_SUFFIX "${LLVM_LIBDIR_SUFFIX}"
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89256.297641.patch
Type: text/x-patch
Size: 423 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201012/e1ac8c36/attachment.bin>


More information about the lldb-commits mailing list