[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

[Pavel Labath via Phabricator via lldb-commits]

labath added a subscriber: jasonmolenda.
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Ah, interesting. We already know of one incompatibility in vFile packets -- it seems you have found a second one.

Making note of this is a good idea. The other incompatibility is mentioned in the Host/File.h, but mentioning it here is a good idea too. If it's not too much of a trouble could you also mention the open flag mismatch issue here?

PS: If you're interested, it would also be very nice to fix this these incompatibilities. The biggest trick is to ensure that things still work with old debugserver isntances (well, lldb-server too, but we don't care about that as much as debugserver). Fixing the flag issue is tricky and would require adding some explicit negotiation about the format. However, for the hex/decimal encoding the path forward is more clear:

- make sure consumers accept both encodings (sounds like lldb-server does -- debugserver would need to be checked too)
- wait a while
- change lldb client encoding


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89227/new/

https://reviews.llvm.org/D89227