[Lldb-commits] [PATCH] D89227: [lldb] Note different vFile:pread/pwrite format for lldb

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a reviewer: labath.
DavidSpickett added a comment.

This is the compatibility issue I mentioned in the other review. I found it investigating why remotely debugging lldb would work with lldb but not gdb, turned out to be a >2gb file causing it but I saw the different formats in the logs.

Source for the gdb side is  binutils-gdb/gdbserver/hostio.cc::handle_pread. Which calls require_int, which tries to convert from hex.

lldb-server side is in source/plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp::Handle_vFile_pRead
and for lldb in source/plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp::ReadFile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89227/new/

https://reviews.llvm.org/D89227