[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Oct 10 11:14:40 PDT 2020


mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:479
+  case XSaveRegSet:
+    // TODO: can WriteRegisterSet() ever be called without ReadRegisterSet()?
+    assert(m_xsave.size() > 0);
----------------
@labath, is this a safe assumption to make? Generally, if `ReadRegisterSet()` is not called, `m_xsave` will be zero-sized.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89193/new/

https://reviews.llvm.org/D89193



More information about the lldb-commits mailing list