[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

BTW, are you running the lldb-server test suite on this? How's it shaping up?

In D88796#2311594 <https://reviews.llvm.org/D88796#2311594>, @mgorny wrote:

> Also a potentially interesting concept would be to unify reg constants between platforms.

Which constants do you have in mind?



================
Comment at: lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:82
 void ProcessFreeBSD::Initialize() {
-  static llvm::once_flag g_once_flag;
+  if (!getenv("FREEBSD_REMOTE_PLUGIN")) {
+    static llvm::once_flag g_once_flag;
----------------
mgorny wrote:
> labath wrote:
> > I would expect that the check above is sufficient, is it not?
> Could you be more specific? I'm pretty sure I had to do this or otherwise the old plugin ended up being used. This is also how windows does it. 
Hmm... interesting. But windows does not have the check in PlatformWindows. Does that mean that check is redundant? I find it strange that we need to check this at two places..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88796/new/

https://reviews.llvm.org/D88796