[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 2 12:26:59 PDT 2020


mib added inline comments.


================
Comment at: lldb/test/API/commands/platform/basic/myshell.c:11
+
+#ifdef WIN32
+  char *cmd_opt = "/C";
----------------
@max-kudr It seems I'm missing the leading `_` (correct me if I'm wrong but IIUC the macro should be `_WIN32`), explaining the failure, I'll send a fix now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86667/new/

https://reviews.llvm.org/D86667



More information about the lldb-commits mailing list