[Lldb-commits] [PATCH] D86817: [lldb] Get rid of LLDB_LIB_DIR and LLDB_IMPLIB_DIR in dotest

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 28 14:20:49 PDT 2020


JDevlieghere created this revision.
JDevlieghere added reviewers: rupprecht, labath, mgorny.
Herald added a subscriber: danielkiss.
JDevlieghere requested review of this revision.

This patch removes the very confusing LLDB_LIB_DIR and LLDB_IMPLIB_DIR environment variables. They are confusing because LLDB_LIB_DIR would point to the `bin` subdirectory in the build root while LLDB_IMPLIB_DIR would point to the `lib` subdirectory. The reason far that was LLDB.framework, which gets build under `bin`. This patch replaces their uses with `configuration.lldb_framework_path` and `configuration.lldb_libs_dir` respectively.


https://reviews.llvm.org/D86817

Files:
  lldb/packages/Python/lldbsuite/test/decorators.py
  lldb/packages/Python/lldbsuite/test/dotest.py
  lldb/packages/Python/lldbsuite/test/lldbtest.py
  lldb/test/API/tools/intel-features/intel-pt/test/TestIntelPTSimpleBinary.py
  lldb/tools/intel-features/intel-mpx/test/TestMPXTable.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86817.288702.patch
Type: text/x-patch
Size: 8524 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200828/d4a5d365/attachment.bin>


More information about the lldb-commits mailing list