[Lldb-commits] [PATCH] D86792: [lldb] Improve test failure reporting for expect()

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 28 09:13:36 PDT 2020


DavidSpickett added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2460
+            matched = output.startswith(startstr)
+            log_lines.append("{} start string: \"{}\" ({})".format(
+                    expecting_str, startstr, found_str(matched)))
----------------
I've added speech marks around things that are probably on the shorter side. I've found it helps narrow down issues with empty strings or leading/trailing whitespace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86792/new/

https://reviews.llvm.org/D86792



More information about the lldb-commits mailing list