[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:174
+  // end of the .text section if the .text section is less than a page size in
+  // length.
+  const uint8_t *ptr = text_data.GetDataStart();
----------------
clayborg wrote:
> I will try and make sure the data is there. The main issue is I don't think you can ask for more bytes than a section has, I believe it will cap the data. But I will check into this.
Never mind, you are reading from the object file's data directly (not the section contents) so this should work just fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86261/new/

https://reviews.llvm.org/D86261