[Lldb-commits] [lldb] b40a381 - [lldb] Code sign binaries with entitlements

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2020-08-19T11:55:36-07:00
New Revision: b40a3814b6fd0c784b52622eddac56d7c321d7cc

URL: https://github.com/llvm/llvm-project/commit/b40a3814b6fd0c784b52622eddac56d7c321d7cc
DIFF: https://github.com/llvm/llvm-project/commit/b40a3814b6fd0c784b52622eddac56d7c321d7cc.diff

LOG: [lldb] Code sign binaries with entitlements

Binaries need to be code signed with entitlements to run on device.

Differential revision: https://reviews.llvm.org/D86237

Added: 
    lldb/packages/Python/lldbsuite/test/make/entitlements.plist

Modified: 
    lldb/packages/Python/lldbsuite/test/builders/darwin.py

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/builders/darwin.py b/lldb/packages/Python/lldbsuite/test/builders/darwin.py
index 704897d4a5f6..470ea5d01db2 100644
--- a/lldb/packages/Python/lldbsuite/test/builders/darwin.py
+++ b/lldb/packages/Python/lldbsuite/test/builders/darwin.py
@@ -1,4 +1,5 @@
 import re
+import os
 import subprocess
 
 from .builder import Builder
@@ -53,9 +54,12 @@ def getExtraMakeArgs(self):
         if configuration.dsymutil:
             args['DSYMUTIL'] = configuration.dsymutil
 
-        os, _ = self.getOsAndEnv()
-        if os and os != "macosx":
-            args['CODESIGN'] = 'codesign'
+        operating_system, _ = self.getOsAndEnv()
+        if operating_system and operating_system != "macosx":
+            builder_dir = os.path.dirname(os.path.abspath(__file__))
+            test_dir = os.path.dirname(builder_dir)
+            entitlements = os.path.join(test_dir, 'make', 'entitlements.plist')
+            args['CODESIGN'] = 'codesign --entitlements {}'.format(entitlements)
 
         # Return extra args as a formatted string.
         return ' '.join(

diff  --git a/lldb/packages/Python/lldbsuite/test/make/entitlements.plist b/lldb/packages/Python/lldbsuite/test/make/entitlements.plist
new file mode 100644
index 000000000000..3c009ffaa59c
--- /dev/null
+++ b/lldb/packages/Python/lldbsuite/test/make/entitlements.plist
@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+    <key>com.apple.security.get-task-allow</key>
+    <true/>
+    <key>com.apple.private.security.no-sandbox</key>
+    <true/>
+</dict>
+</plist>