[Lldb-commits] [PATCH] D85968: [lldb] Forcefully complete a type when adding nested classes

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:233
 
-static void CompleteExternalTagDeclType(TypeSystemClang &ast,
-                                        ClangASTImporter &ast_importer,
-                                        clang::DeclContext *decl_ctx,
-                                        DWARFDIE die,
-                                        const char *type_name_cstr) {
+static void ForcefullyCompleteType(CompilerType type, TypeSystemClang &ast) {
+  bool started = TypeSystemClang::StartTagDeclarationDefinition(type);
----------------
You could just get the TypeSystemClang from the `type` (passing a different TypeSystemClang that is not `type.getTypeSystem()` would lead to strange bugs, so we might as well make that situation impossible by not giving the caller the option).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85968/new/

https://reviews.llvm.org/D85968