[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 14 00:34:10 PDT 2020


labath added a comment.

In D85539#2216197 <https://reviews.llvm.org/D85539#2216197>, @JDevlieghere wrote:

> Even though this file is called "base", there's no inheritance going on here, it's just methods and `lldbtest.py` will import the appropriate module. I considered this too, but didn't feel like rewriting those files as a classes for this small change. But if we're going to pass the `TRIPLE`, `OS` and `VERSION` separately, we might as well.

I'd just send the final ARCH_CFLAGS value. Then the Android.rules makefile could be ported to python as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85539/new/

https://reviews.llvm.org/D85539



More information about the lldb-commits mailing list