[Lldb-commits] [PATCH] D85904: [lldb] Check Decl kind when completing -flimit-debug-info types

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 13 14:07:28 PDT 2020


shafik accepted this revision.
shafik added a comment.

Minor comment but LGTM, nice fix!



================
Comment at: lldb/test/API/functionalities/limit-debug-info/main.cpp:34
+  int member = 47;
+} shadowed_one;
+
----------------
Just to clarify we `func_shadow::One` is being shadowed here. Maybe a comment would help clarify the what is going on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85904/new/

https://reviews.llvm.org/D85904



More information about the lldb-commits mailing list