[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

[Frederic Riss via Phabricator via lldb-commits]

friss added inline comments.


================
Comment at: lldb/source/Commands/CommandObjectThread.cpp:486-490
+      // NonStopMode runs all threads down in the ProcessPlugin layer, but
+      // at this level we need to pretend we are actually only running this
+      // thread.  So functionally it does the same thing as
+      // GetSteppingRunsAllThreads.  So it overrides the runs all threads
+      // setting.
----------------
jingham wrote:
> friss wrote:
> > It feels like the last sentence shouldn't be there.
> > 
> > Also, the comment doesn't explain *why* "we need to pretend". 
> Is this better?  
Yes, although it still doesn't explain why this implementation detail matters. The comment makes it sound it shouldn't matter. It would be great to document what would break if we didn't set it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85265/new/

https://reviews.llvm.org/D85265