[Lldb-commits] [PATCH] D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary

Davide Italiano via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 5 16:08:31 PDT 2020


davide added inline comments.


================
Comment at: lldb/source/Target/TargetList.cpp:110-111
+    // architecture so that the platform matching can be more accurate.
+    if (!platform_arch.TripleOSWasSpecified() ||
+        !platform_arch.TripleVendorWasSpecified()) {
+      prefer_platform_arch = true;
----------------
Is this check strict enough? I thought it should be only TripleOSWasSpecified -- what we can infer from the vendor?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85049/new/

https://reviews.llvm.org/D85049



More information about the lldb-commits mailing list